insert-annotation-to-source: issues with simultaneous declarations

[GoogleCodeExporter]

Test.java contains a simultaneous declaration of fields a and b:

Object a,b;

Test1.jaif annotates a and b with SuppressWarnings(...)
Test2.jaif annotates a with @NonNull, b with @Nullable


What steps will reproduce the problem?
1. javac Test.java
2. insert-annotations-to-source Test1.jaif Test.java
3. javacheck annotated/Test.java
4. insert-annotations-to-source Test2.jaif Test.java

What is the expected output? What do you see instead?
Output from step 3:
annotated/Test.java:5: error: duplicate annotation, the declaration of 
SuppressWarnings does not have a valid Repeatable annotation
  @SuppressWarnings({"nonnull","rawness","nullness"})
  ^
1 error

Output from step 4:
Found class Test, but unable to insert @checkers.nullness.quals.Nullable:
  @checkers.nullness.quals.Nullable (nl=true) @ [GenericArrayLocationCriterion at outermost type, FieldCriterion: b, In class 'Test' (exactly), In class 'Test' (exactly)]


Ideally, the simultaneous declaration should be expanded to one declaration per 
field.

What version of the product are you using? On what operating system?
hg head on linux.

Please provide any additional information below.

Original issue reported on code.google.com by mattsbr...@g.ucla.edu on 7 May 2013 at 8:44

Attachments:

• Test.java
• Test1.jaif
• Test2.jaif

[dbrosoft]

Test FieldMultiple has been corrected and disabled until there is a fix.

[CharlesZ-Chen]

Just write this as a note for others who also meet the "multiple declarations" problem:

I've searched a bit on existing refactor tools that could refactor multiple declarations in one statement. However I didn't find anyone works.

I've filed an issue on google-java-format here:

google/google-java-format#104

But at the moment nobody gives a response on this issue.

Thus, as a workaround, I write a simple and ugly refactor that specifically refactor multiple declarations:

https://github.com/CharlesZ-Chen/multiDeclRefactor

This refactor could work as a pre-processor before doing annotation insertion on a project. However, since I developed it in a catch-the-DDL way, the code is a bit unordered and not good for maintenance. It should be just a temporary workaround, and hopefully later on some mature & professional refactor tools could solve this problem wonderfully.