From 8e1dfc7168dbf770448e9c543555fd2efb6f6258 Mon Sep 17 00:00:00 2001 From: Georgi Krastev Date: Tue, 12 May 2020 22:15:50 +0200 Subject: [PATCH] Add partialComparison syntax --- core/src/main/scala/cats/syntax/partialOrder.scala | 1 + tests/src/test/scala/cats/tests/PartialOrderSuite.scala | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/core/src/main/scala/cats/syntax/partialOrder.scala b/core/src/main/scala/cats/syntax/partialOrder.scala index 7a4b38c04a..e4476c6296 100644 --- a/core/src/main/scala/cats/syntax/partialOrder.scala +++ b/core/src/main/scala/cats/syntax/partialOrder.scala @@ -13,6 +13,7 @@ final class PartialOrderOps[A](lhs: A)(implicit A: PartialOrder[A]) { def <=(rhs: A): Boolean = A.lteqv(lhs, rhs) def partialCompare(rhs: A): Double = A.partialCompare(lhs, rhs) + def partialComparison(rhs: A): Option[Comparison] = A.partialComparison(lhs, rhs) def tryCompare(rhs: A): Option[Int] = A.tryCompare(lhs, rhs) def pmin(rhs: A): Option[A] = A.pmin(lhs, rhs) def pmax(rhs: A): Option[A] = A.pmax(lhs, rhs) diff --git a/tests/src/test/scala/cats/tests/PartialOrderSuite.scala b/tests/src/test/scala/cats/tests/PartialOrderSuite.scala index 8ecb00831b..cc01a087eb 100644 --- a/tests/src/test/scala/cats/tests/PartialOrderSuite.scala +++ b/tests/src/test/scala/cats/tests/PartialOrderSuite.scala @@ -49,9 +49,10 @@ class PartialOrderSuite extends CatsSuite { (i <= j) should ===(PartialOrder.lteqv(i, j)) checkPartialCompare(i.partialCompare(j), PartialOrder.partialCompare(i, j)) - (i.tryCompare(j)) should ===(PartialOrder.tryCompare(i, j)) - (i.pmin(j)) should ===(PartialOrder.pmin(i, j)) - (i.pmax(j)) should ===(PartialOrder.pmax(i, j)) + i.partialComparison(j) should ===(PartialOrder[POrd].partialComparison(i, j)) + i.tryCompare(j) should ===(PartialOrder.tryCompare(i, j)) + i.pmin(j) should ===(PartialOrder.pmin(i, j)) + i.pmax(j) should ===(PartialOrder.pmax(i, j)) } } }