Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctest sbt command no longer fails when individual test fails #2758

Closed
kailuowang opened this issue Mar 26, 2019 · 3 comments
Closed

doctest sbt command no longer fails when individual test fails #2758

kailuowang opened this issue Mar 26, 2019 · 3 comments

Comments

@kailuowang
Copy link
Contributor

This is quite puzzling to me.
When I run sbt coreJVM/test after intentionally breaking a doc test.
I can see

[info] ! NonEmptyChain.scala.NonEmptyChain.scala:63: fromSeq.example at line 67: cats.data.NonEmptyChain.fromSeq(collection.immutable.Seq(12, ...: Falsified after 0 passed tests.
[info] > Labels of failing property: 
[info] 'Some(Chain(12, 2, 3))' is not equal to 'Some(Chain(1, 2, 3))'

but the final result is

[info] Passed: Total 66, Failed 0, Errors 0, Passed 66
[success] Total time: 12 s, completed Mar 25, 2019 9:31:48 PM

One thing I noticed that is the total test 66 seems very low.

@ceedubs
Copy link
Contributor

ceedubs commented Mar 26, 2019

@kailuowang I can't explain it, but I think that #2734 fixes this issue. See my comment in #2735.

@kailuowang
Copy link
Contributor Author

ah I misread your comment there. thanks for pointing that out. In that case I propose we merge #2734 now just to fix this (it's scary to have failing test passing build)

@kailuowang
Copy link
Contributor Author

Confirmed that this is closed by #2734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants