Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add combineAllOption to Foldable #2363

Closed
jrduncans opened this issue Aug 4, 2018 · 4 comments
Closed

Add combineAllOption to Foldable #2363

jrduncans opened this issue Aug 4, 2018 · 4 comments

Comments

@jrduncans
Copy link

combineAllOption should be added to Foldable as a parallel to combineAll for Semigroup instead of Monoid
@johnynek
Copy link
Contributor

johnynek commented Aug 4, 2018

Seems like a nice PR but will have to be done with careful binary compatibility concerns.

@barambani barambani mentioned this issue Aug 10, 2018
Merged
@Krever Krever mentioned this issue Oct 23, 2019
Closed
@LLCampos
Copy link
Contributor

I think this one can be closed? #2380 was already merged. :)

@johnynek
Copy link
Contributor

yeah, I think so, although, I noticed that PR didn't override toIterable for the common collections (List, Vector, SortedSet, SortedMap could all just return themselves).

@johnynek johnynek mentioned this issue Aug 18, 2021
Merged
@johnynek
Copy link
Contributor

here is a PR that leverages toIterable more: #3967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johnynek @jrduncans @LLCampos