Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Prod / Coproduct to ProductK / CoproductK #1582

Closed
fommil opened this issue Mar 30, 2017 · 6 comments · Fixed by #1589
Closed

rename Prod / Coproduct to ProductK / CoproductK #1582

fommil opened this issue Mar 30, 2017 · 6 comments · Fixed by #1589

Comments

@fommil
Copy link

fommil commented Mar 30, 2017

The problem is that we already have scala.Product and shapeless.Coproduct and that means it is easy to get the wrong import.

In addition, it is very unfortunate that cats and shapeless (the foundations of this FP stack) should have a name conflict on something so simple.

I understand that the K postfix is appropriate for a higher kinded thing as a workaround until scala/scala#5538 become ubiquitous. I suppose M would also be appropriate?

@diesalbla
Copy link
Contributor

¿Could they be called TupleK or PairK, and EitherK? That would make it a bit more clear the relation to their 0-Kind counterparts.

@kailuowang
Copy link
Contributor

I vote for Tuple2K and EitherK, I think they are more accurate than ProductK and CoproductK which have no set arity.

@kailuowang kailuowang changed the title rename Product / Coproduct to ProductK / CoproductK rename Prod / Coproduct to ProductK / CoproductK Mar 31, 2017
@kailuowang kailuowang reopened this Mar 31, 2017
@edmundnoble
Copy link
Contributor

@kailuowang Makes sense to me; should we add a ProductK and CoproductK (or at least just the CoproductK) to avoid fixing an arity?

@kailuowang
Copy link
Contributor

@edmundnoble sure, if there is need for them. Do you think they should go into 1.0.0-RC1 though? if not maybe we should create another issue for them?

@kailuowang
Copy link
Contributor

Seems that the opinion we got so far favors renaming to Tuple2K and EitherK. I am going to go ahead creating a PR.

@fommil
Copy link
Author

fommil commented Apr 5, 2017

Produkt and Coprodukt :trollface:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants