From fc1fe42f5116f6396002ed93c9e1d4ab2c13fc79 Mon Sep 17 00:00:00 2001 From: David Strawn Date: Tue, 21 Dec 2021 11:50:02 -0700 Subject: [PATCH] Remove Size Check Optimization It makes the code confusing, and it is _possible_ that someone is using an implementation of SortedMap which doesn't have a precomputed size. --- .../cats/kernel/instances/SortedMapInstances.scala | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/kernel/src/main/scala/cats/kernel/instances/SortedMapInstances.scala b/kernel/src/main/scala/cats/kernel/instances/SortedMapInstances.scala index 3dde56c1e11..2a429383a4f 100644 --- a/kernel/src/main/scala/cats/kernel/instances/SortedMapInstances.scala +++ b/kernel/src/main/scala/cats/kernel/instances/SortedMapInstances.scala @@ -50,12 +50,7 @@ private[instances] class SortedMapOrder[K, V](implicit K: Order[K], V: Order[V]) if (x eq y) { 0 } else { - x.size.compare(y.size) match { - case 0 => - StaticMethods.iteratorCompare(x.iterator, y.iterator) - case otherwise => - otherwise - } + StaticMethods.iteratorCompare(x.iterator, y.iterator) } } @@ -65,12 +60,7 @@ private[instances] class SortedMapPartialOrder[K, V](implicit K: PartialOrder[K] if (x eq y) { 0.0 } else { - PartialOrder[Int].partialCompare(x.size, y.size) match { - case 0 => - StaticMethods.iteratorPartialCompare(x.iterator, y.iterator) - case otherwise => - otherwise - } + StaticMethods.iteratorPartialCompare(x.iterator, y.iterator) } }