-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Async#evalOn(executor)
or Async#evalOnExecutor(executor)
#3633
Comments
Just to understand more clearly. You would like to add Or you want to change the initialization of the blockingExectionContext so when it fails, it would generate a report through |
We already have this one :) cats-effect/kernel/shared/src/main/scala/cats/effect/kernel/Async.scala Lines 161 to 167 in 7e24bb9
I propose we add: def evalOn[A](fa: F[A], exec: java.util.concurrent.Executor): F[A] |
@armanbilge could you please review the PR attached to the issue, if possible? If you could not, I'd be glad if you'd tell me who could review the PR. Thanks! |
Async#evalOn
takes a ScalaExecutionContext
but frequently this functionality is needed for running on a JavaExecutor
.ExecutionContext.fromExecutor(...)
can be used to get anExecutionContext
from anExecutor
We can do even better, by using the current
ExecutionContext
sreportFailure
method for the newExecutionContext
built from theExecutor
. This is better than the default reporter.The text was updated successfully, but these errors were encountered: