Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest: let's forward _all_ the ServerCapabilities to tsserver #626

Open
4 tasks
NullVoxPopuli opened this issue Oct 3, 2023 · 3 comments
Open
4 tasks

Comments

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Oct 3, 2023

Goal:

Achieve parity between tsserver and glint so that folks don't feel the need to have both servers active (which would consume more RAM)

Each capability should be its own PR -- some PRs will be more involved from others, and some may be straight-forward.


Here is where we need to configure: https://github.com/typed-ember/glint/blob/main/packages/core/src/language-server/binding.ts#L19

"ServerCapabilities"

Here is the full list:
https://github.com/microsoft/vscode-languageserver-node/blob/main/protocol/src/common/protocol.ts#L1068

Features we want?

(and probably more)

Here are the features from reported requests we can add

@camerondubas
Copy link
Contributor

@NullVoxPopuli I'd be happy to help with this. I have a little bit of experience with language servers, but not a ton. Could you point me in the right direction to get started?

@NullVoxPopuli
Copy link
Contributor Author

Hello!, given the list of server capabilities in protocol.ts (linked above), is there a particular one you'd like to start with implementing?

we only want one server capabilities addition per PR (for ease of testing)

@IgnaceMaes
Copy link
Contributor

Thanks for setting up this initiative!

Two features I would like to see as well are:

  • The TypeScript: Sort Imports command
image
  • Inlay type hints to show inferred types inline
image image

I haven't done any digging so no clue how straight forward these should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants