-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to test usage of addon? #34
Comments
Hey @GCheung55, @rwwagner90 wrote some tests for the addon itself: https://github.com/kybishop/ember-attacher/blob/master/tests/integration/components/ember-attacher-test.js Are there more specific things you're hoping to test that aren't illustrated in the tests for the addon? |
@kybishop the tests are I'm looking to test that the popper opened and closed when expected. It would be helpful to provide instructions on how to test for someone unfamiliar with Popper.js and the markup used in the addon. |
@GCheung55 they are not |
@rwwagner90, the tests are tl;dr: Whoever is more familiar with the addon's code, and perhaps Popper.js, can that person add examples of how to test the usage of this addon in the README? As a user, how do I test my usage of Test helpers would be nice, but not necessary as long as there are examples on how to check that the popper has opened/closed, at least for me. |
@GCheung55 I'll add a section to the README with examples on testing visible/not visible. If someone wants to add similar test helpers to those in ember-tooltips, I'm happy to accept a PR ;) |
The tests are slowly being flushed out. Progress can be tracked in #40. I've added a task to update the README once we've tested at least the default behavior. |
Can instructions be added to the README on how to test usage of this addon?
Test helpers would also be useful.
The text was updated successfully, but these errors were encountered: