From 7ad95442025d0cf54c3e6072d89d47c7d0a92a0d Mon Sep 17 00:00:00 2001 From: nickonometry Date: Fri, 20 Sep 2024 09:48:14 -0400 Subject: [PATCH] chore: story code cleanup and updated documentation --- .../components/confirmation-dialog/ConfirmationDialog.mdx | 4 +--- .../confirmation-dialog/ConfirmationDialog.stories.ts | 8 +++++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/stories/components/confirmation-dialog/ConfirmationDialog.mdx b/src/stories/components/confirmation-dialog/ConfirmationDialog.mdx index 7e52768..dd7d981 100644 --- a/src/stories/components/confirmation-dialog/ConfirmationDialog.mdx +++ b/src/stories/components/confirmation-dialog/ConfirmationDialog.mdx @@ -5,8 +5,6 @@ import * as ConfirmationDialogStories from './ConfirmationDialog.stories'; -Confirmation dialogs convey a brief message or alert. For alerts that are one sentence or less, the dialog title can be excluded. They may be closed by clicking outside of the dialog, or by clicking a dismissive action. These dialogs display the same in mobile and desktop contexts. +Confirmation dialogs are designed to convey a brief message or alert, up to 2 sentences. For alerts that are a single sentence, the dialog title can be excluded. They may be closed by clicking outside of the dialog, pressing escape, or by clicking a dismissive action. These dialogs display the same in mobile and desktop contexts. <Canvas of={ConfirmationDialogStories.Demo} /> - -Description here diff --git a/src/stories/components/confirmation-dialog/ConfirmationDialog.stories.ts b/src/stories/components/confirmation-dialog/ConfirmationDialog.stories.ts index c58ee87..e4692d8 100644 --- a/src/stories/components/confirmation-dialog/ConfirmationDialog.stories.ts +++ b/src/stories/components/confirmation-dialog/ConfirmationDialog.stories.ts @@ -46,14 +46,16 @@ const meta = { <forge-confirmation-dialog ${ref(confirmationDialogRef)} @forge-confirmation-dialog-action=${(e: IConfirmationDialogAction) => onConfirmationDialogAction(e)} + @forge-dialog-close=${closeDialog} ?open=${args.open} .isBusy=${args.isBusy} .showTitleText=${args.showTitleText} - .titleText="${args.titleText}" + .titleText=${args.titleText} .message=${args.message} .showSecondaryButton=${args.showSecondaryButton} .secondaryButtonText=${args.secondaryButtonText} .primaryButtonText=${args.primaryButtonText}> + <div slot="message">Are you sure you want to reset your settings?</div> </forge-confirmation-dialog> `; }, @@ -61,8 +63,8 @@ const meta = { open: false, isBusy: false, showTitleText: true, - titleText: 'Reset settings?', - message: 'Are you sure you want to reset your device to its default settings?', + titleText: 'Delete selected images?', + message: 'Images will be permanently removed from your account and all synced devices.', showSecondaryButton: true, secondaryButtonText: 'No', primaryButtonText: 'Yes',