feat: redis transaction for all storage updates in block #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment suggests you planned to add this, and indeed it makes sense. This executes all the commands needed to process a particular block at once which means we can't query data as it is still being updated. This prevents, for example, race conditions when reading data while updating balances per transaction input/output.
The
redis
crate support for transactions does not seem suitable for our needs and also does not provide methods for theMULTI
andEXEC
commands required to perform a transaction, for this reason we manually create the commands.MULTI
starts the transaction, and all commands that follow it are queued until aEXEC
command is sent.Is there any issues here where something might happen to prevent the
EXEC
to end the transaction being called?