feat: Implement stateful cursor #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvcas
approved these changes
May 28, 2022
rvcas
reviewed
May 28, 2022
| CRDTCommand::block_starting(block), | ||
| ))?; | ||
|
|
||
| for reducer in self.reducers.iter_mut() { |
There was a problem hiding this comment.
Is this where we plan to use rayon or something to do these in parallel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a stateful cursor in a similar fashion to the one in Oura.
This works by using the same storage plugin configured for the actual data output. The value of the cursor is scoped for a specific pipeline (aka: Scrolls process). When the pipeline starts, it queries the storage plugin to get the value of the cursor. If we find a value, it will override any "intersect" configuration and use the cursor instead.
The cursor is updated each time a block is done with all reducer algorithms. This introduces a new requirement: reducers need to be synchronized at the block level. Meaning, we can't have reducers sending update commands from one block while a different reducer is still processing the previous block. To enforce we'll need to merge each reducer algorithm into a single stage and parallelize the process within the scope of a block.