Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making changes to tx builder model #553

Merged

Conversation

logicalmechanism
Copy link
Contributor

@logicalmechanism logicalmechanism commented Dec 9, 2024

Adding a signature to a conway era transaction causes a called Result::unwrap()on anErr value: CorruptedTxBytes error.

let signed_tx_cbor = tx
    // called `Result::unwrap()` on an `Err` value: CorruptedTxBytes
    .add_signature(witness_public_key, witness_vector)
    .unwrap()
    .tx_bytes;

This error comes from line 685 in model.rs of the txbuilder.

If you change the babbage call into a conway call then it does not throw the error.

This PR changes the babbage to conway on all the things. Also, it adjusts the witness building as pushing to a set is not possible and requires coverting back to a vector then back to an empty set.

This PR passes all current tests. There is no open issue on this topic as it brought up in discord.

@logicalmechanism
Copy link
Contributor Author

I also commented out a debug statement that clutters the terminal screen.

@scarmuega scarmuega merged commit e9b7ec2 into txpipe:main Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants