making changes to tx builder model #553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a signature to a conway era transaction causes a
called
Result::unwrap()on an
Errvalue: CorruptedTxBytes
error.This error comes from line 685 in model.rs of the txbuilder.
If you change the
babbage
call into aconway
call then it does not throw the error.This PR changes the
babbage
toconway
on all the things. Also, it adjusts the witness building as pushing to a set is not possible and requires coverting back to a vector then back to an empty set.This PR passes all current tests. There is no open issue on this topic as it brought up in discord.