feat(multiplexer): Allow fine-grained control of concurrency strategy #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the hardcoded threads from inside the multiplexer and provides fine-grained methods for the implementor to decide how to approach concurrency.
A multiplexer is now divided into two different structs: Muxer and Demuxer. Each of this structures provides the following methods:
tick
: to perform a single atomic mux / demux operation.block
: to enter a continuous loop of muxing / demuxing operations, blocking the thread indefinitely.To achieve the same thread-based concurrency as before, two helper methods are included as part of the refactoring:
spawn_muxer
andspawn_demuxer
, which creates a thread that performs the correspondingblock
operation.Having the low-level operations exposed to the library consumer opens up the possibility to explore other concurrency mechanism:
join
mechanism (maybe?): single loop where muxer / demuxer ticks are parallelized only if threads are available