Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Plutus Data hashing / JSON #100

Merged
merged 3 commits into from
Apr 29, 2022
Merged

feat: Implement Plutus Data hashing / JSON #100

merged 3 commits into from
Apr 29, 2022

Conversation

scarmuega
Copy link
Member

After some source code spelunking, this PR adds:

  • a mechanism to hash Plutus Data from wire-cbor in an equivalent fashion as the cardano-cli.
  • export a Plutus Data struct into JSON format that can be read by the cardano-cli

@scarmuega scarmuega marked this pull request as ready for review April 29, 2022 13:16
@scarmuega scarmuega requested a review from rvcas April 29, 2022 13:17
rvcas
rvcas approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@rvcas rvcas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Is this in a spec somewhere or was this from reverse-engineering some Haskell?

@scarmuega
Copy link
Member Author

I use "spelunking" as an euphemism for "reverse engineering"

@scarmuega scarmuega merged commit 2c41c17 into main Apr 29, 2022
@scarmuega scarmuega deleted the feat/datum-hash branch April 29, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvcas rvcas rvcas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scarmuega @rvcas