Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atom_init.json #2

Closed
felentovic opened this issue Sep 21, 2018 · 2 comments
Closed

atom_init.json #2

felentovic opened this issue Sep 21, 2018 · 2 comments

Comments

@felentovic
Copy link

I was inspecting atom_init.json file and I found something strange in comparison to the documentation of atom features in the table S2 (Supplemental Material).

  • Since every feature is one hot encoded, length of the vector should be 93 according to the table, but it is actually 92.

  • Also Group number feature has 18 categories in the table, but in the file it has 19. Actinide and lanthanide elements are presented by having 1 at element with index 0, except Lutetium which is labeled as group number 3. Other elements have an element equal to 1 on the same index as their group number, e.g. for hydrogen, element at index number 1 is 1.

  • Regarding the Period number feature it says it has 9 categories, but in the file it has 7 since lathanide and actinide elements are described with period 6 and 7 respectively and not 8 and 9 as stated in the table S2.

  • Could you also explain why hydrogen's electronegativity is in the bin [1.9 - 2.25) instead of [2.25-2.6) according to Sanderson electronegativity, i.e. 2.59.

@txie-93
Copy link
Owner

txie-93 commented Sep 21, 2018

I used the mendeleev package to generate the atom initialization vectors. You can find the definitions for each atom property from their website. The definitions in the table S2 come from an older version.

Actually, the atom initialization vectors are not so important when data size is large (Fig. S3), but they can be helpful when you only have ~10^3 data points. Feel free to experiment your own atom initialization vectors.

@shrimonmuke0202
Copy link

Hi, which version of the mendeleev package you have used to create the features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants