Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOException rescue is too broad #12

Open
dentarg opened this issue Dec 2, 2015 · 1 comment
Open

IOException rescue is too broad #12

dentarg opened this issue Dec 2, 2015 · 1 comment
Labels
enhancement

Comments

@dentarg
Copy link
Contributor

dentarg commented Dec 2, 2015

At https://github.com/twingly/ecco/blob/v0.5.0/lib/ecco/client.rb#L49 we rescue IOException, and always return Ecco::Error::ConnectionError, but we could improve that and return different errors for different situations.

mysql-binlog-connector-java has AuthenticationException that inherits from ServerException that inherits IOException.

At https://github.com/twingly/ecco/blob/v0.5.0/spec/integration/client_spec.rb#L273 we could expect the authentication error I think.
@dentarg
Copy link
Contributor Author

dentarg commented Feb 26, 2016

Examples:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dentarg