Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using up+right keyboard in the table makes the soft focus go one cell too far. #462

Closed
lucasbordeau opened this issue Jun 28, 2023 · 4 comments · Fixed by #3269
Closed

Using up+right keyboard in the table makes the soft focus go one cell too far. #462

lucasbordeau opened this issue Jun 28, 2023 · 4 comments · Fixed by #3269
Labels
blocked: conflict/dependency scope: front Issues that are affecting the frontend side only size: short

Comments

@lucasbordeau
Copy link
Contributor

To reproduce : go to an entity table cell and and do up and down rapidly, it should go one cell too far.
@lucasbordeau lucasbordeau mentioned this issue Jun 29, 2023
Closed
@Bonapara Bonapara moved this from 🆕 New to 📋 Backlog in Product development ✅ Jul 13, 2023
@FelixMalfait
Copy link
Member

I was able to reproduce by pressing ⬆️ and ➡️ at the same time on my keyboard

@FelixMalfait FelixMalfait added the scope: front Issues that are affecting the frontend side only label Jul 24, 2023
@brendanlaschke
Copy link
Contributor

The cause seems to be in the react-hotkeys-hook library as wrong events are sent while the keyup event not has been registered:
JohannesKlauss/react-hotkeys-hook#1013

@FelixMalfait
Copy link
Member

@brendanlaschke thanks a lot for finding/pointing out the right issue. I've subscribed to it

@FelixMalfait FelixMalfait mentioned this issue Sep 15, 2023
Closed
@brendanlaschke
Copy link
Contributor

Update: the fix has been merged we are waiting for a new release of https://github.com/JohannesKlauss/react-hotkeys-hook

@brendanlaschke brendanlaschke mentioned this issue Jan 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Product development ✅ Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked: conflict/dependency scope: front Issues that are affecting the frontend side only size: short
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update react-hotkeys-hook brendanlaschke/twenty
3 participants
@FelixMalfait @lucasbordeau @brendanlaschke