Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt website footer for mobile and tablet version #4029

Closed
FelixMalfait opened this issue Feb 16, 2024 · 7 comments
Closed

Adapt website footer for mobile and tablet version #4029

FelixMalfait opened this issue Feb 16, 2024 · 7 comments
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@FelixMalfait
Copy link
Member

FelixMalfait commented Feb 16, 2024

We currently have two tools to build our website Twenty.com:

  • Framer, which is well suited for beautiful landing pages
  • A Next.js website which is used for pages that need dynamic content (e.g. pull github data or markdown files)

Example page managed by Framer: https://twenty.com/
Example page managed by NextJS: https://twenty.com/user-guide (it's ugly! and not launched. Will be redesigned soon!)

We've done a quick v1 for the footer which you can see on the NextJS page.
But we didn't adapt that design to work on mobile and tablet as it it is on the https://twenty.com/ website.

The goal of this ticket is to copy the behavior of the Framer website on mobile/tablet and implement it on the NextJS version.

Would be amazing if we use an object as source of truth for all links and not copy/paste into 3 files.

Screenshot 2024-02-16 at 18 09 54

Code for NextJS website is in: https://github.com/twentyhq/twenty/tree/main/packages/twenty-website

@FelixMalfait FelixMalfait added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only labels Feb 16, 2024
@essofyany
Copy link

Hi @FelixMalfait ,
I'd like to work on this issue.

@Kanav-Arora
Copy link
Contributor

Hi @essofyany

We have a PR down the line in which we are planning to introduce screensize hook in twenty-website. So to avoid any issues I'll be sharing the file path, name and code. Please use that hook to render different pages.

@essofyany
Copy link

Hi @Kanav-Arora
cool, can you share with me the PR link so I can take a look?

@Kanav-Arora
Copy link
Contributor

Kanav-Arora commented Feb 17, 2024

@essofyany

I'll be commit code in this PR #3984

@Kanav-Arora
Copy link
Contributor

Hi @essofyany
Check the PR for file useDeviceType file. Please follow same directory structure to avoid any merge conflicts in the future.

@FelixMalfait
Copy link
Member Author

Hey we merged the PR but it turns out useDeviceType isn't a good solution. We should use https://emotion.sh/docs/media-queries#facepaint instead - fix coming soon

@FelixMalfait
Copy link
Member Author

Ok the new method is finally merged - this is the best approach! #4169

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in 🎯 Roadmap & Sprints Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
Archived in project
Development

No branches or pull requests

4 participants