Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a ActivationStatus in core.workspace and use it in front to redirect properly #3959

Closed
martmull opened this issue Feb 14, 2024 · 2 comments · Fixed by #3989
Closed
Assignees

Comments

@martmull
Copy link
Contributor

Currently, we use some artefact to infer if a workspace schema is created or not. This occurs some useless redirections that impact front performances. We should have a computed field in workspace entity that gives the information wether a workspace has a schema or not, and use that field in the front

@martmull martmull self-assigned this Feb 14, 2024
@martmull martmull linked a pull request Feb 14, 2024 that will close this issue
@charlesBochet
Copy link
Member

@FelixMalfait @Bonapara I'm not fully convince by activationStatus = 'active' | 'inactive'. I'm mixed between it actually being an 'onboardingStatus': 'creation_pending' | 'completed' and it being a 'schemaStatus' = 'pending' | 'created' | 'hybernated'
I think it's fine as we don't plan to actually create this field in database and compute it on the fly but we could use some product vision input to clarify this, it will help build a better code logic!

@FelixMalfait
Copy link
Member

@charlesBochet I agree it's not ideal but not a big deal since this is code-only and not db-level. I'm fine with any option. Could be creationStatus too. This will probably evolve in any case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants