Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency type is not implemented in optimistic cache update #3806

Closed
charlesBochet opened this issue Feb 5, 2024 · 3 comments · Fixed by #3907
Closed

Currency type is not implemented in optimistic cache update #3806

charlesBochet opened this issue Feb 5, 2024 · 3 comments · Fixed by #3907
Assignees
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short

Comments

@charlesBochet
Copy link
Member

Bug Description

  • Go to /companies table page
  • filter on a currency field (example ARR)
  • update a record in the table
  • You should see a red snack bar "Not implemented yet" appearing

Technical inputs

The error is triggered by our optimistic update of our cache ; we are trying to update the filtered query results based on the update but the Currency field type is not supported yet
Update packages/twenty-front/src/modules/object-record/record-filter/utils/isRecordMatchingFilter.ts to support Currency type

@charlesBochet charlesBochet added type: bug good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short labels Feb 5, 2024
Copy link

sentry-io bot commented Feb 5, 2024

Sentry issue: PROD-8J

@anoopw3bdev
Copy link
Contributor

Hi @charlesBochet I had created a PR for this issue. Could you please assign this issue to me if its okay.

@FelixMalfait
Copy link
Member

Thanks @anoopw3bdev!

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in 🎯 Roadmap & Sprints Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants