Skip to content

Commit 10f1b19

Browse files
committed
Don't track lib/settings in nixpkgs toolchain
The issue does not occur in the nixpkgs toolchain as the file is always present in the Nix store, regardless of whether Bazel tracks it. Tracking it requires exporting it from the `nixpkgs_package` `BUILD` file for `@rules_haskell_ghc_nixpkgs`. The `BUILD` file defaults to the template defined in `rules_nixpkgs` and can be overridden by the user, meaning adding required targets is a breaking change. Given that it is not required to track the settings file in the nixpkgs use-case, it is better to avoid the breaking change.
1 parent b8f0f52 commit 10f1b19

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

haskell/nixpkgs.bzl

+1-6
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ Available versions:
5151
name = "toolchain-impl",
5252
libraries = "toolchain_libraries",
5353
# See Note [GHC toolchain files] in haskell/ghc_bindist.bzl
54-
files = ["@rules_haskell_ghc_nixpkgs//:lib/{}/settings".format(ghc_name)],
54+
files = [],
5555
tools = ["@rules_haskell_ghc_nixpkgs//:bin"],
5656
version = repr(repository_ctx.attr.version),
5757
static_runtime = repository_ctx.attr.static_runtime,
@@ -83,11 +83,6 @@ filegroup(
8383
srcs = glob(["bin/*"]),
8484
)
8585
86-
filegroup(
87-
name = "lib",
88-
srcs = glob(["lib/*"]),
89-
)
90-
9186
{toolchain_libraries}
9287
9388
{toolchain}

0 commit comments

Comments
 (0)