Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming of redeemers smart constructors in skeleton #438

Closed
florentc opened this issue Jul 19, 2024 · 0 comments · Fixed by #449
Closed

Improve naming of redeemers smart constructors in skeleton #438

florentc opened this issue Jul 19, 2024 · 0 comments · Fixed by #449
Labels
enhancement New feature or request

Comments

@florentc
Copy link
Member

florentc commented Jul 19, 2024

Very tiny nitpicking issue.

For now, there is txSkelSomeRedeemer and txSkelEmptyRedeemer to pass redeemers to scripts in skeletons. There is also txSkelRedeemer which is a field accessor in skeletons (actually TxSkelRedeemer but the spirit is the same).

This is a bit confusing when using the user facing API. Completion pops up txSkelRedeemer easily instead of txSkelSomeRedeemer. Besides, the txSkel prefix should be used for field accessors only out of consistency.

I would advocate for dropping txSkel and renaming those to someRedeemer and emptyRedeemer. We could even just have redeemer and use () when empty (although we would lose a bit of abstraction).

@florentc florentc added the enhancement New feature or request label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant