From 4c827b1bf094a2daba4e46c6c51dd6ad695ed38b Mon Sep 17 00:00:00 2001 From: Christian Oliff Date: Wed, 14 Nov 2018 22:31:38 +0900 Subject: [PATCH 1/9] enforce lowercase class name in .stylelintrc `"selector-class-pattern": "^[a-z]+([a-z0-9]?|[a-z0-9\\-]*[a-z0-9])$"` I think this could be a useful addition, to prevent anyone using a class name against the projects guidelines - mixed case or using underscores etc. REF: http://codeguide.co/#css-classes --- .stylelintrc | 1 + 1 file changed, 1 insertion(+) diff --git a/.stylelintrc b/.stylelintrc index e3cb0d7cc4a4..fb5573481804 100644 --- a/.stylelintrc +++ b/.stylelintrc @@ -294,6 +294,7 @@ "scss/operator-no-newline-before": true, "scss/operator-no-unspaced": true, "selector-attribute-quotes": "always", + "selector-class-pattern": "^[a-z]+([a-z0-9]?|[a-z0-9\\-]*[a-z0-9])$", "selector-list-comma-newline-after": "always", "selector-list-comma-newline-before": "never-multi-line", "selector-list-comma-space-after": "always-single-line", From 9c06b6baea37b125e9d868f591bc01f1b3cef79e Mon Sep 17 00:00:00 2001 From: Christian Oliff Date: Fri, 16 Nov 2018 15:23:46 +0900 Subject: [PATCH 2/9] Update .stylelintrc --- .stylelintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.stylelintrc b/.stylelintrc index fb5573481804..dac9edbf4386 100644 --- a/.stylelintrc +++ b/.stylelintrc @@ -294,7 +294,7 @@ "scss/operator-no-newline-before": true, "scss/operator-no-unspaced": true, "selector-attribute-quotes": "always", - "selector-class-pattern": "^[a-z]+([a-z0-9]?|[a-z0-9\\-]*[a-z0-9])$", + "selector-class-pattern": "^[a-z][a-z0-9\\-]*[a-z0-9]$", "selector-list-comma-newline-after": "always", "selector-list-comma-newline-before": "never-multi-line", "selector-list-comma-space-after": "always-single-line", From 684c9e01cf5a9aefa383d07ed582af35ed3564b1 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Sat, 17 Nov 2018 13:25:57 +0200 Subject: [PATCH 3/9] Update _syntax.scss --- site/docs/4.1/assets/scss/_syntax.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/docs/4.1/assets/scss/_syntax.scss b/site/docs/4.1/assets/scss/_syntax.scss index e66c5da2205b..c03e800f8ae7 100644 --- a/site/docs/4.1/assets/scss/_syntax.scss +++ b/site/docs/4.1/assets/scss/_syntax.scss @@ -1,4 +1,4 @@ -// stylelint-disable declaration-block-single-line-max-declarations +// stylelint-disable declaration-block-single-line-max-declarations, selector-class-pattern .hll { background-color: #ffc; } .c { color: #999; } From eabec5c6a8951a6c69a81a4c852c3ed804eebe1d Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Sat, 17 Nov 2018 13:37:37 +0200 Subject: [PATCH 4/9] Remove unneeded escape --- .stylelintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.stylelintrc b/.stylelintrc index dac9edbf4386..a1f59d9d6465 100644 --- a/.stylelintrc +++ b/.stylelintrc @@ -294,7 +294,7 @@ "scss/operator-no-newline-before": true, "scss/operator-no-unspaced": true, "selector-attribute-quotes": "always", - "selector-class-pattern": "^[a-z][a-z0-9\\-]*[a-z0-9]$", + "selector-class-pattern": "^[a-z][a-z0-9\-]*[a-z0-9]$", "selector-list-comma-newline-after": "always", "selector-list-comma-newline-before": "never-multi-line", "selector-list-comma-space-after": "always-single-line", From eff3f277bb4fd767572dafd858f16710d92742bd Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Sat, 17 Nov 2018 13:41:58 +0200 Subject: [PATCH 5/9] Update .stylelintrc --- .stylelintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.stylelintrc b/.stylelintrc index a1f59d9d6465..dac9edbf4386 100644 --- a/.stylelintrc +++ b/.stylelintrc @@ -294,7 +294,7 @@ "scss/operator-no-newline-before": true, "scss/operator-no-unspaced": true, "selector-attribute-quotes": "always", - "selector-class-pattern": "^[a-z][a-z0-9\-]*[a-z0-9]$", + "selector-class-pattern": "^[a-z][a-z0-9\\-]*[a-z0-9]$", "selector-list-comma-newline-after": "always", "selector-list-comma-newline-before": "never-multi-line", "selector-list-comma-space-after": "always-single-line", From 942844f3bc5eb93f2023f27539c7858934497ed7 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Sat, 17 Nov 2018 13:45:31 +0200 Subject: [PATCH 6/9] Update .stylelintrc --- .stylelintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.stylelintrc b/.stylelintrc index dac9edbf4386..51aa887e200e 100644 --- a/.stylelintrc +++ b/.stylelintrc @@ -294,7 +294,7 @@ "scss/operator-no-newline-before": true, "scss/operator-no-unspaced": true, "selector-attribute-quotes": "always", - "selector-class-pattern": "^[a-z][a-z0-9\\-]*[a-z0-9]$", + "selector-class-pattern": "^[a-z]{2,}[a-z0-9\\-]+[a-z0-9]$", "selector-list-comma-newline-after": "always", "selector-list-comma-newline-before": "never-multi-line", "selector-list-comma-space-after": "always-single-line", From d5dd13f124b6eb74bbdb46f4c064c2337eecda88 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Sat, 17 Nov 2018 13:49:12 +0200 Subject: [PATCH 7/9] Update .stylelintrc --- .stylelintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.stylelintrc b/.stylelintrc index 51aa887e200e..421ef48d8769 100644 --- a/.stylelintrc +++ b/.stylelintrc @@ -294,7 +294,7 @@ "scss/operator-no-newline-before": true, "scss/operator-no-unspaced": true, "selector-attribute-quotes": "always", - "selector-class-pattern": "^[a-z]{2,}[a-z0-9\\-]+[a-z0-9]$", + "selector-class-pattern": "^[a-z]{2,}[a-z0-9\\-]?[a-z0-9]$", "selector-list-comma-newline-after": "always", "selector-list-comma-newline-before": "never-multi-line", "selector-list-comma-space-after": "always-single-line", From 6610fbec8ffdb271fed2ee768658d05d23be0848 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Sat, 17 Nov 2018 13:50:09 +0200 Subject: [PATCH 8/9] Update .stylelintrc --- .stylelintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.stylelintrc b/.stylelintrc index 421ef48d8769..7e4331d14569 100644 --- a/.stylelintrc +++ b/.stylelintrc @@ -294,7 +294,7 @@ "scss/operator-no-newline-before": true, "scss/operator-no-unspaced": true, "selector-attribute-quotes": "always", - "selector-class-pattern": "^[a-z]{2,}[a-z0-9\\-]?[a-z0-9]$", + "selector-class-pattern": "^[a-z]{2,}[a-z0-9\\-]*[a-z0-9]$", "selector-list-comma-newline-after": "always", "selector-list-comma-newline-before": "never-multi-line", "selector-list-comma-space-after": "always-single-line", From 0aad306ec22a2ea78a54d8150b612559cb6c251d Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Sat, 17 Nov 2018 13:51:56 +0200 Subject: [PATCH 9/9] Update .stylelintrc --- .stylelintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.stylelintrc b/.stylelintrc index 7e4331d14569..dac9edbf4386 100644 --- a/.stylelintrc +++ b/.stylelintrc @@ -294,7 +294,7 @@ "scss/operator-no-newline-before": true, "scss/operator-no-unspaced": true, "selector-attribute-quotes": "always", - "selector-class-pattern": "^[a-z]{2,}[a-z0-9\\-]*[a-z0-9]$", + "selector-class-pattern": "^[a-z][a-z0-9\\-]*[a-z0-9]$", "selector-list-comma-newline-after": "always", "selector-list-comma-newline-before": "never-multi-line", "selector-list-comma-space-after": "always-single-line",