Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unnecessary col-form-label from form row docs #24335

Merged
merged 2 commits into from
Oct 18, 2017
Merged

Removes unnecessary col-form-label from form row docs #24335

merged 2 commits into from
Oct 18, 2017

Conversation

andresgalante
Copy link
Collaborator

This PR removes unnecessary col-form-label from form row docs

cc/ @mdo @XhmikosR

@Herst
Copy link
Contributor

Herst commented Oct 11, 2017

Is this related to #23824? Does that mean .form-control-label would also be useless there?

@siddharthkp siddharthkp mentioned this pull request Oct 11, 2017
Merged
@andresgalante
Copy link
Collaborator Author

@Herst You are right on #23824. I left a note there.

I believe that this PR is still valid.

mdo
mdo approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, these aren't needed here because this isn't a horizontal grid layout. Thanks!

@XhmikosR XhmikosR merged commit 217d344 into v4-dev Oct 18, 2017
@XhmikosR XhmikosR deleted the v4-dev-andres-cleanup-forms-docs branch October 18, 2017 16:59
@mdo mdo mentioned this pull request Oct 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
docs v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andresgalante @Herst @mdo @XhmikosR