Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no rounded corners if there is only one card in a card-group. #24080

Merged
merged 2 commits into from
Sep 25, 2017
Merged

Fix no rounded corners if there is only one card in a card-group. #24080

merged 2 commits into from
Sep 25, 2017

Conversation

drobson03
Copy link

No description provided.

@XhmikosR
Copy link
Member

@andresgalante

@andresgalante
Copy link
Collaborator

I've just pulled @SpicyDwarf branch and tested it. This PR fixes the issue. Let me describe it better:

When you have only one card inside a card-group the first and last child selector will not affect it since it's the only child. Then it looks like this:

screen shot 2017-09-25 at 5 51 01 pm

This PR is introducing the border radius if the card group container has only one card inside.

@SpicyDwarf Nice job!

@XhmikosR XhmikosR requested a review from mdo September 25, 2017 20:58
@XhmikosR XhmikosR merged commit 2727456 into twbs:v4-dev Sep 25, 2017
@mdo mdo mentioned this pull request Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants