Fix media-breakpoint-between #23997
Merged
Fix media-breakpoint-between #23997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling .scss that uses media-breakpoint between with xs as the lower bound or xl as the upper bound, a compilation error can occur due to $min/$max being set to null, or the resulting .css can be invalid (see issue #23965). (This is basically the same fix that was applied to media-breakpoint-only a short time ago).
houndci-bot
reviewed
Sep 19, 2017
scss/mixins/_breakpoints.scss
Outdated
| @@ -81,8 +81,18 @@ | |||
| $min: breakpoint-min($lower, $breakpoints); | |||
| $max: breakpoint-max($upper, $breakpoints); | |||
|
|
|||
| @media (min-width: $min) and (max-width: $max) { | |||
| @content; | |||
| @if $min != null and $max !=null { | |||
There was a problem hiding this comment.
$max !=null should be written with a single space on each side of the operator: $max != null
Make houndci-bot recommended changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling .scss that uses media-breakpoint between with xs as the lower bound or xl as the upper bound, a compilation error can occur due to $min/$max being set to null, or the resulting .css can be invalid (see issue #23965).
(This is basically the same fix that was applied to media-breakpoint-only a short time ago).