Add eslint-plugin-compat #23972
Merged
Add eslint-plugin-compat #23972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
reviewed
Sep 17, 2017
| 'Opera >= 30' | ||
| ] | ||
| } | ||
| autoprefixer: {} |
There was a problem hiding this comment.
why did you let that line ? their are nothing in autoprefixer
There was a problem hiding this comment.
How will autoprefixer be included otherwise?
XhmikosR
force-pushed
the
v4-dev-xmr-eslint-plugin-compat
branch
2 times, most recently
from
f24c4a2
to
912af1d
Compare
|
I ignored the |
XhmikosR
force-pushed
the
v4-dev-xmr-eslint-plugin-compat
branch
from
912af1d
to
0213511
Compare
|
@Johann-S: what do we do with this? |
XhmikosR
force-pushed
the
v4-dev-xmr-eslint-plugin-compat
branch
from
0213511
to
dbf9585
Compare
|
IMO we should merge this PR because currently folks PR aren't tested on Saucelabs so it will help folks to know if their code is compatible with our supported browsers |
This is so other plugins can use it too.
We can check for browser compatibility on lint time now.
XhmikosR
force-pushed
the
v4-dev-xmr-eslint-plugin-compat
branch
from
dbf9585
to
57655e4
Compare
Johann-S
approved these changes
Sep 26, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we can move the browserlists config to a separate file; I went with package.json so that we don't have one more file.