Moves theme variables outside the theme map #23918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgalante
changed the title
XhmikosR
force-pushed
the
color-variable
branch
from
db1e189
to
13ba674
Compare
XhmikosR
force-pushed
the
color-variable
branch
from
13ba674
to
0fa35ec
Compare
|
@andresgalante: I rebased this. @mdo: lgty? |
mdo
approved these changes
Oct 19, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #23908
@kriim makes a valid point on using and changing theme variables. You cannot overwrite the variables inside the map unless you actually change the source, which is something you wouldn't want to do.
This PR move theme variables outside the map as suggested by @kriim