Fixes input group btn height bug #23810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgalante
force-pushed
the
input-height
branch
from
fe73370
to
7994ff5
Compare
andresgalante
force-pushed
the
input-height
branch
from
7994ff5
to
73593b1
Compare
|
I hope that fixes the issue also for a (content-editable) div inside of the input-group. |
|
@alecpl I'd have to test it, but I think that as long as you add the class |
|
Here is a codepen to demo the fix: https://codepen.io/andresgalante/pen/QMXRwa |
|
@mdo, It would be nice to have it in beta2. I also tested the change and works for me. Thanks. |
|
Nice! |
This was referenced Oct 2, 2017
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from this PR #23806.
The elements within input-group now stretches to avoid bugs like the one described on #23745, it now looks like this:
@mattcheah Please feel free to take this PR as an example to fix yours if you want. If you do please close this PR
This is fixing the problems introduced on this commit: 02ae73f
Fixes #23745