Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all lint targets in test script. #23685

Merged
merged 1 commit into from
Aug 26, 2017
Merged

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Aug 26, 2017

@Johann-S: can you check if we are missing something else?

Fixes #23164.

@XhmikosR XhmikosR requested a review from Johann-S August 26, 2017 08:24
@XhmikosR XhmikosR changed the title Run all lint target in test script. Run all lint targets in test script. Aug 26, 2017
Copy link
Member

@Johann-S Johann-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@XhmikosR
Copy link
Member Author

@Johann-S: any other targets we might be missing to run on CI?

@XhmikosR XhmikosR force-pushed the v4-dev-run-docs-lint-in-test branch from e576c8d to be270fe Compare August 26, 2017 10:11
@XhmikosR
Copy link
Member Author

Freaking saucelabs is failing and I can't merge.

@mdo: I think we need to remove the restrictions :)

@Johann-S
Copy link
Member

That's happen sometimes when we push a lot and Saucelabs is used a lot

@XhmikosR XhmikosR merged commit e60c451 into v4-dev Aug 26, 2017
@XhmikosR XhmikosR deleted the v4-dev-run-docs-lint-in-test branch August 26, 2017 11:57
@mdo mdo mentioned this pull request Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants