Collapse - preventDefault only on <a> elements not inside the collapse element #23666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Aug 25, 2017
| @@ -57,7 +57,7 @@ <h5 class="mb-0"> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <script src="../../../docs/assets/js/vendor/jquery-slim.min.js"></script> | |||
There was a problem hiding this comment.
Can you go through all visual test files and see if there are more references like that and replace all of them?
There was a problem hiding this comment.
It was the only one I forget 😄 (I made a check)
XhmikosR
requested changes
Aug 25, 2017
js/src/collapse.js
Outdated
| @@ -361,7 +361,8 @@ const Collapse = (($) => { | |||
| */ | |||
|
|
|||
| $(document).on(Event.CLICK_DATA_API, Selector.DATA_TOGGLE, function (event) { | |||
| if (!/input|textarea/i.test(event.target.tagName)) { | |||
| // preventeDefault only for <a> elements (which change the URL) | |||
Johann-S
force-pushed
the
v4-collapse-preventdefault
branch
from
3bd59ea
to
d7d80ad
Compare
XhmikosR
approved these changes
Aug 25, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent default only on
<a>elements not inside the collapse element/CC @nelisbijl
Close: #22866