Ensure active button styles are not applied to disabled buttons

[prateekgoel]

I have added the styles same as .disabled to .disabled:active.
This should fix #23353.

Let me know if any other changes are required.

[patrickhlauke]

Haven't had a chance to test it, but one question that pops into my head: are there situations where a .disabled element receives the programmatically set .active class? I think our scripts should check for that/prevent that.

If .active isn't set to things that are .disabled, I'd slim down the rules to only cover :active pseudo

[prateekgoel]

I am not sure if any disabled element receives .active class.
If someone can confirm, it would be great. We can eliminate some rules then.
CC @mdo

[andresgalante]

Hi, Why is this duplicated?

&.disabled:active,
&:disabled:active

[prateekgoel]

Hi @andresgalante,
These two lines are not exactly same. First one applies to active state of button having .disabled class and the second one applies to active state of disabled button with disabled attribute.

[andresgalante]

right! sorry I miss read the : and the .
Thanks for the clarification

[patrickhlauke]

an alternative, more terse way (instead of redefining :active/.active for when the button is disabled) would be to make the current active selectors more specific, e.g. &:not([disabled]):not(.disabled):active, &:not([disabled]):not(.disabled).active - or would that be too cryptic?

[prateekgoel]

Sorry @patrickhlauke , didn't get you.
Using :not will target the buttons that are not disabled. We need to target the disabled buttons, right?

[patrickhlauke]

@prateekgoel what i mean is: instead of redefining new styles for disabled+active scenario, you could likely save yourself all the redefinition by instead making the current active styles for buttons only target buttons that aren't disabled.

[patrickhlauke]

i.e. not adding new style blocks, and instead changing

&:active,
&.active

to

&:not([disabled]):not(.disabled):active,
&:not([disabled]):not(.disabled).active

[prateekgoel]

Yes, got your point. Seems a nice idea.
I will do this change and update the PR.

[prateekgoel]

Thanks for the suggestion. 😃

[prateekgoel]

@patrickhlauke Did the changes.

[patrickhlauke]

Sorry for the delay...but finally able to build locally and test, and it works well (even in IE11) :)