Add margin variable for breadcrumb #23138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 22, 2017
scss/_variables.scss
Outdated
| @@ -787,6 +787,8 @@ $breadcrumb-padding-y: .75rem !default; | |||
| $breadcrumb-padding-x: 1rem !default; | |||
| $breadcrumb-item-padding: .5rem !default; | |||
|
|
|||
| $breadcrumb-margin: 0 0 1rem! default; | |||
There was a problem hiding this comment.
Invalid CSS after "... 0 0 1rem!": expected identifier, was " default;"
mdo
reviewed
Jul 25, 2017
| @@ -1,6 +1,6 @@ | |||
| .breadcrumb { | |||
| padding: $breadcrumb-padding-y $breadcrumb-padding-x; | |||
| margin-bottom: 1rem; | |||
There was a problem hiding this comment.
Leave it as margin-bottom, please. There's no need to reset a non-existant margin-top, -right, and -left if we have no intention of ever applying those values (which I don't :p).
There was a problem hiding this comment.
Ok then i'll keep margin-bottom only.
Will do the change.
There was a problem hiding this comment.
@mdo Changes done.
There was a problem hiding this comment.
@mdo Can you please review and close this PR if we don't have any more changes?
|
This'll go in for Beta 2 at the earliest. |
|
Ok Thanks @mdo |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a variable for breadcrumb margin to
_variables.scssand replaced static margin in_reboot.csswith that variable.Fixes #23016.