Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pointer-events declarations to modal for easier custom close handling #22704

Merged
merged 2 commits into from
Aug 22, 2017
Merged

Add pointer-events declarations to modal for easier custom close handling #22704

merged 2 commits into from
Aug 22, 2017

Conversation

patrickhlauke
Copy link
Member

make outer .modal-dialog pass through events for custom click handling (making it possible to just listen on the .modal-backdrop for any clicks), then counteract it for the actual .modal-content

Closes #22493

make outer `.modal-dialog` pass through events for custom click
handling, counteract it for the actual `.modal-content`
@patrickhlauke patrickhlauke added this to the v4.0.0-beta milestone May 26, 2017
@mdo mdo modified the milestones: v4.0.0-beta.2, v4.0.0-beta May 26, 2017
@mdo
Copy link
Member

mdo commented May 26, 2017

Cool! Saving this for Beta 2.

Copy link

@colltoaction colltoaction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdo mdo removed this from the v4.0.0-beta.2 milestone Jun 18, 2017
@XhmikosR XhmikosR requested a review from mdo August 13, 2017 12:16
@mdo mdo merged commit 6ca451e into twbs:v4-dev Aug 22, 2017
@mdo mdo mentioned this pull request Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants