Fix border on input group elements and custom form inputs #22612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3e4cbd changed the border of input elements to be translucent. This commit makes input group elements and custom form inputs follow the same pattern.
|
This might be perfect! I'm trying to prioritize only the essentials for our first beta though, so going to wait just a bit on merging this <3. |
This was referenced May 26, 2017
mdo
approved these changes
Aug 11, 2017
Closed
|
Shouldn't we change the color of the border when the input is focused as well? |
|
Indeed it looks very weird once the textbox is focused. In the given examples from @nwoltman it would look even more strange. |
mdo
added a commit
that referenced
this pull request
Oct 2, 2017
Turns out #22612 is a bad idea and it makes all sorts of weird visual glitches when working with form controls and transparent borders.
mdo
added a commit
that referenced
this pull request
Oct 2, 2017
Turns out #22612 is a bad idea and it makes all sorts of weird visual glitches when working with form controls and transparent borders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c3e4cbd changed the border of input elements to be translucent. This makes input group elements and custom form inputs follow the same pattern.
Fixes #21098