Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First child of input group segmented buttons are off by $input-btn-border-width #22495

Merged
merged 3 commits into from
Oct 3, 2017

Conversation

pat270
Copy link
Contributor

@pat270 pat270 commented Apr 22, 2017

http://v4-alpha.getbootstrap.com/components/input-group/#segmented-buttons

Input group with input-group-btn as first child that have multiple buttons inside are off by $input-btn-border-width.

Edit: Made the selector more specific

@oktalk
Copy link

oktalk commented Apr 28, 2017

Is this in reference to a known issue? Your code change doesn't do anything since the left margin is already 0. Also, I'm not sure what you're trying to solve.

PR's have a better chance of getting through if you can create an issue requesting the PR first.

@pat270
Copy link
Contributor Author

pat270 commented Apr 28, 2017

Hey @oktalk,

I don't think this is a reference to a known issue. It's just something I stumbled across while using v4. It's hard to see on the docs page because the segmented button component isn't working. If you add flex-direction: row; to .input-group you can see it a bit better. Here is a gif of what I'm seeing.

bs4-segmented-buttons

It's not that noticeable because the borders are only 1px, but it becomes more apparent if you increase $input-btn-boder-width to something like 5px. This is what it looks like with this fix.

bs4-segmented-buttons-fixed

@oktalk
Copy link

oktalk commented Apr 28, 2017

Thanks for the GIF. I see it now. That would be hard to explain without visuals.

@mdo mdo modified the milestone: v4.0.0-beta.2 Jun 1, 2017
@mdo mdo removed this from the v4.0.0-beta.2 milestone Jun 18, 2017
@mdo
Copy link
Member

mdo commented Oct 2, 2017

Looks good, and added another fix for a related issue.

@mdo mdo merged commit 864c657 into twbs:v4-dev Oct 3, 2017
@mdo mdo mentioned this pull request Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants