Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel #9307

Closed
wlingke opened this issue Aug 10, 2013 · 3 comments
Closed

Carousel #9307

wlingke opened this issue Aug 10, 2013 · 3 comments

Comments

@wlingke
Copy link

wlingke commented Aug 10, 2013

Several suggestions:

Small item:
White captions are hard to see on many images. I would suggest a back semi-transparent background behind

Bigger item:
Ability to specify a width & height for the carousel and then size appropriately and vertically & horizontally center an image in carousel. Sizing requires setting either a max-width, max-height to 100% and auto for the other dimension. Add a black-background for styling.

This prevents the carousel from changing height based on the image size and makes the carousel able to handle many types of images.

I hope this makes sense... if not, let me know and I'll try to work up an example.

@Merg1255
Copy link

Nice suggestions!
Also, I'd like to add: make a fade transition
Having the slide + fade transitions, it will cover most of the most common cases in websites. The ones who want more effects can use a plugin.

@cvrebert
Copy link
Collaborator

@Merg1255 Please file a separate bug. Too many things in one issue right now.

@mdo
Copy link
Member

mdo commented Aug 13, 2013

Feedback on each item:

  • For now we'll leave the captions as-is—that should be easy to add if you want them.
  • Setting width and height is interesting, but I don't know how we'd do it for everyone without fucking up something for someone else.
  • Open to a black background on carousel items—throw a PR out there if you like :).

I've addressed @Merg1255's request in #9397.

@mdo mdo closed this as completed Aug 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants