Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: .popover-inner wrapper div not present in static examples #6533

Closed
maniqui opened this issue Jan 10, 2013 · 2 comments
Closed

Docs: .popover-inner wrapper div not present in static examples #6533

maniqui opened this issue Jan 10, 2013 · 2 comments
Labels
Milestone

Comments

@maniqui
Copy link

maniqui commented Jan 10, 2013

The markup of popovers on the static examples in Docs don't have a <div class="popover-inner"></div> wrapping the contents (.popover-title and .popover-content).

Example of markup (copied from docs page source) of a static popover:

     <div class="popover top">
        <div class="arrow"></div>
        <h3 class="popover-title">Popover top</h3>
        <div class="popover-content">
          <p>Sed posuere consectetur est at lobortis. Aenean eu leo quam. Pellentesque ornare sem lacinia quam venenatis vestibulum.</p>
        </div>
      </div>

Example of markup (copied from docs js-generated page DOM) of a live popover:

  <div class="popover fade right in" style="top: 2.5px; left: 242px; display: block; ">
    <div class="arrow"></div>
    <div class="popover-inner">
      <h3 class="popover-title">A Title</h3>
      <div class="popover-content">
          And here's some amazing content. It's very engaging. right?
      </div>
    </div>
  </div>

I'm not sure if the popover-inner is essential (it seems not) or old markup, or just optional markup that may allow better styling or scripting.
Some clarification on docs about it would be helpful.

@mdo
Copy link
Member

mdo commented Jan 11, 2013

It is not necessary and should have been removed. I'll update that in #6346.

@mdo
Copy link
Member

mdo commented Jan 11, 2013

Fixed in 2.3.0-wip. Thanks!

@mdo mdo closed this as completed Jan 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants