Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global configuration to enable the use of calc Fixed #40611

Closed
wants to merge 1 commit into from

Conversation

Riyazul555
Copy link

@Riyazul555 Riyazul555 commented Jul 7, 2024

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #40412

@Riyazul555 Riyazul555 requested a review from a team as a code owner July 7, 2024 09:41
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR @Riyazul555
However, this version doesn't compile:

Error: Undefined variable.
    ╷
246 │     $return-calc: $global-return-calc;

Please also fill the PR template with the description, the checkboxes, etc.
The global variable(s) must also probably be documented.

Putting it back to draft.

@julien-deramond
Copy link
Member

Closing as no action has been made to fix the Sass compilation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add global configuration and methods to enable the use of calc by default in numeric operations
4 participants