Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark mode bug in /examples/sidebars/ #38679

Closed
3 tasks done
endcoreAK opened this issue May 31, 2023 · 2 comments · Fixed by #38711
Closed
3 tasks done

dark mode bug in /examples/sidebars/ #38679

endcoreAK opened this issue May 31, 2023 · 2 comments · Fixed by #38711

Comments

@endcoreAK
Copy link

Prerequisites

Describe the issue

if you switch to dark mode on the example page, the background on sidebar 2 +3 is lighter than the others, also the blue on the active pills is different than the icons (3rd sidebar) and last but not least I noticed that under account (4th sidebar) the links are dark.

Reduced test cases

https://getbootstrap.com/docs/5.3/examples/sidebars/

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

No response

What version of Bootstrap are you using?

5.3.0-alpha3

@julien-deramond
Copy link
Member

Thanks for submitting this issue @endcoreAK.
Dark links are definitely an issue to fix.
Regarding the difference between the background and active colors, I might need some guidance about the expected rendering by @mdo in dark mode. I can still propose a draft PR to fix everything with my own vision of it, but I'm no designer.

@mdo
Copy link
Member

mdo commented Jun 6, 2023

Only plan is to fix link color. Rest of the changes are good to keep—we change link color in dark mode, but we don't (yet) change the main theme colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants