Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: callouts have horribly low contrast #37745

Closed
3 tasks done
Tracked by #37549
patrickhlauke opened this issue Dec 28, 2022 · 2 comments · Fixed by #37781
Closed
3 tasks done
Tracked by #37549

Docs: callouts have horribly low contrast #37745

patrickhlauke opened this issue Dec 28, 2022 · 2 comments · Fixed by #37781

Comments

@patrickhlauke
Copy link
Member

Prerequisites

Describe the issue

In the new docs, info and warning callouts have text colour contrast that's below minimum 4.5:1 threshold.

Info callout

info callout

Text: #087990
Background: #CFF4FC
Contrast: 4.34:1


Link: #0D6EFD
Background: #CFF4FC
Contrast: 3.86:1


Code: #D63384
Background: #CFF4FC
Contrast: 3.86:1

Warning callout

warning callout

Text: #997404
Background: #FFF3CD
Contrast: 3.9:1


Link: #0D6EFD
Background: #FFF3CD
Contrast: 4.06:1


Code: #D63384
Background: #FFF3CD
Contrast: 4.06:1

Reduced test cases

https://getbootstrap.com/docs/5.3/components/popovers/

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of Bootstrap are you using?

5.3

@mdo
Copy link
Member

mdo commented Jan 2, 2023

Overall colors and their links in default light mode are good now in main.

CleanShot 2023-01-01 at 22 15 29@2x

CleanShot 2023-01-01 at 22 17 20@2x

Pushing a PR to address the code color though, which will look like this:

CleanShot 2023-01-01 at 22 22 53@2x

CleanShot 2023-01-01 at 22 22 36@2x

@patrickhlauke
Copy link
Member Author

lovely, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants