Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Radio Button Group #30615

Closed
einfallstoll opened this issue Apr 19, 2020 · 8 comments · Fixed by #30650
Closed

Documentation for Radio Button Group #30615

einfallstoll opened this issue Apr 19, 2020 · 8 comments · Fixed by #30650

Comments

@einfallstoll
Copy link

At the moment the documentation for grouped button-styled radio buttons is located in the "Buttons" component. However, I think it should be placed (or at least referenced) in the "Button Groups" component or the "Forms" component page. What do you think?

@mdo
Copy link
Member

mdo commented Apr 19, 2020

Could probably do a cross link of some kind—right now it's there because it's powered by the button JS plugin.

@patrickhlauke
Copy link
Member

patrickhlauke commented Apr 19, 2020

noting that - if this does go through in the end - for the non-JS based version in future, we [edit: well, I in this case] were planning to have proper mentions in both "buttons" and "button groups" #28463

@tumbleshack
Copy link

I'd like to give this a shot by adding a reference to the details from "Button Groups" and from "Forms"

I'm new to contributing and eager to learn :)

@tumbleshack
Copy link

There appears to already be a link from Button Groups to the button plugin:

Wrap a series of buttons with .btn in .btn-group. Add on optional JavaScript radio and checkbox style behavior with [our buttons plugin]({{< docsref "/components/buttons#button-plugin" }}).

Is this correct or am I looking at the wrong branch?

@einfallstoll
Copy link
Author

@tumbleshack You're correct. However this issue refers to the button group styled radio buttons. Maybe we can improve the existing text?

@vishalsharma2063
Copy link

can be fix by grouping all together

@twbs twbs deleted a comment May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@mdo @einfallstoll @patrickhlauke @tumbleshack @vishalsharma2063 and others