Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should row-cols-* support auto-sizing? #29866

Closed
kosmiq opened this issue Dec 17, 2019 · 1 comment · Fixed by #28517
Closed

Should row-cols-* support auto-sizing? #29866

kosmiq opened this issue Dec 17, 2019 · 1 comment · Fixed by #28517

Comments

@kosmiq
Copy link

kosmiq commented Dec 17, 2019

Bootstrap 4.4.0 added the row-cols-* classes (awesome job btw, so nice to have).

I did notice that it does not add classes for autosizing columns based on breakpoints and that might be something to add.

Consider the following case:

  • For small devices we set .row-cols-2
  • For medium devices .row-cols-md-4
  • But for some reason we might want large devices to auto-size the columns, thus arises the need for .row-cols-lg-auto (not currently existing)

This is currently solvable by setting .row-cols-2.row-cols-md-4 on the row and then setting .col-lg-auto on the individual cols.

I think that this addition would give even greater flexibility in using the new .row-cols without the need to add classes to the nested columns.

I can create a PR for it, if we decide that it is a worthwhile addition. I read through parts of the discussion with row-cols but didn't manage to find anything regarding this (sorry if I have missed any prior discussions about it).

@MartijnCuppens
Copy link
Member

sorry if I have missed any prior discussions about it

Nope, you haven't afaik. Your request makes sense, I might include this in the new grid (see #28517), or do a separate PR if it gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants