Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

box-sing _reboot.scss #29576

Closed
theking2 opened this issue Oct 23, 2019 · 1 comment
Closed

box-sing _reboot.scss #29576

theking2 opened this issue Oct 23, 2019 · 1 comment
Labels

Comments

@theking2
Copy link

theking2 commented Oct 23, 2019

I search and found a 5 year old issue on the box-sizing reset to border-box. It did refert to https://www.paulirish.com/2012/box-sizing-border-box-ftw/

The current code in bootstrap (4.3.1) is a bit different which potentially clashes with 4-rd party styles;

    *,
    *::before,
    *::after {
         box-sizing: border-box; // 1
    }

Paul Irish article has been updated since and, for good reason, to a bit different code:

html {
  box-sizing: border-box;
}
*, *:before, *:after {
  box-sizing: inherit;
}

which yields slightly better compatibility. (see article update 2014)

Would it be possible to update this? Or would it break to much existing code?

@MartijnCuppens
Copy link
Member

Chrome has an inheritance bug for elements in details (see #22872 for more details), that's why we stick to the current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants