Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified theme colors map can not change color of some components #27801

Closed
ysds opened this issue Dec 7, 2018 · 2 comments
Closed

Modified theme colors map can not change color of some components #27801

ysds opened this issue Dec 7, 2018 · 2 comments
Labels

Comments

@ysds
Copy link
Member

ysds commented Dec 7, 2018

From my comment: #27712 (comment).

About a way of changing the theme colors, the document explains as:
https://getbootstrap.com/docs/4.1/getting-started/theming/#modify-map

But, it actually is incorrect after #27378.

demo1: https://codepen.io/fellows3/pen/WYBbEM

$theme-colors: (
  "primary": green
);

demo2: https://codepen.io/fellows3/pen/ZmNYNd

$primary: green;
@MartijnCuppens
Copy link
Member

I think we'll need to revert to the state before #27378 to avoid breaking changes.

The way we define colors need to be reviewed at some point because we do not document what the purpose of $primary is in our documentation.

Ref: #23908

@mdo
Copy link
Member

mdo commented Dec 14, 2018

I'm okay with reverting that other PR if it solves this problem for now. We can revisit how we use maps/variables with our v5 changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants