-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: side Modals #27033
Comments
@MartijnCuppens I really need this. Would love it if you could share the SCSS changes for this! |
@myorangeca, you can find the code in the PR #27035 |
This looks really good! Have you seen this (#21540) PR? Not sure how it compares.... |
@coliff, I only searched for "side modals" in the open issues and did not came across that PR. Thanks for mentioning it. There are some differences in the PR's though:
I see there is a bit of discussion in #21540 to make a new component instead of extending the modal functionality. The reason I chose to extend is that modals actually have all the functionality that the drawer need (the API, the keyboard accessibility). I think we would have a lot of duplicate code if we're going to make another component for this. |
I love this, and really want this in basically all of my projects as the nav (hamburger) menu. |
I was recently working on a project where I themed a Bootstrap modal as a side drawer. I made an implementation that is compatible with the modal sizing classes. Maybe this is something that's nice to have in Bootstrap by default?
Demo: https://codepen.io/MartijnCuppens/pen/OwwjWV?editors=1100
PR incomming...
The text was updated successfully, but these errors were encountered: