Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: iOS 7-8 compatibility #24941

Closed
andris-05 opened this issue Dec 4, 2017 · 4 comments
Closed

Feature request: iOS 7-8 compatibility #24941

andris-05 opened this issue Dec 4, 2017 · 4 comments

Comments

@andris-05
Copy link

Currently Bootstrap 4 beta 2 is not compatible with browsers on iOS 7 - 8. Below you can see visitor data from my website (last 6 months, unique visitors). As you can see iOS 7 - 8 users account for 0.83% of total users, far more than IE10. This is far too many users (and revenue) just to ignore.

To make the grid compatible you would have to add the "-webkit-" prefix to all flexbox related properties, I'm sure there are other instances where css fixes would have to be applied.
ios-7-8

@wolfy1339
Copy link
Contributor

wolfy1339 commented Dec 4, 2017

This is in the works, it might be added as unofficial support

@Herst
Copy link
Contributor

Herst commented Dec 4, 2017

It's worth noting that it's no problem concerning jQuery 3 as it also supports iOS 7.

@mdo
Copy link
Member

mdo commented Dec 27, 2017

#24919 added WebKit prefixes, so closing out.

@mdo mdo closed this as completed Dec 27, 2017
@mdo mdo added the has-pr label Dec 27, 2017
@amydepalma
Copy link

amydepalma commented Jan 23, 2018

Hello! I'm not sure that #24919 resolved the issue to add support for iOS 8 (I don't have access to iOS 7 and Cross Browser doesn't have it so I couldn't test). I looked at the Bootstrap Examples page on an iPad Air 8.1 and ran cross browser testing -- the columns don't wrap to the next row.

I believe instead of "display: -webkit-box;", it should be "display: -webkit-flex;" and the .col's don't have the appropriate -webkit prefixes. For example:

.col-1 {
-webkit-box-flex: 0;
-ms-flex: 0 0 8.333333%;
flex: 0 0 8.333333%;
max-width: 8.333333%;
}

should be

.col-1 {
-webkit-flex: 0 0 8.333333%; /* Notice the shrink and basis is added here; 'box' is removed */
-ms-flex: 0 0 8.333333%;
flex: 0 0 8.333333%;
max-width: 8.333333%
}

There are a few other properties that should have "-box" removed in favor of just "-webkit-flex-PROPERTYNAME." There would be a few more CSS changes in regards to the utility classes as well.

To note, I have only looked at (and am only using) the grid version, so I am sure there are other instances in the components that use flexbox that I am not aware of.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants