Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal rule hard-coded margin introduced in Beta #24517

Closed
ernestbofill opened this issue Oct 23, 2017 · 1 comment
Closed

Horizontal rule hard-coded margin introduced in Beta #24517

ernestbofill opened this issue Oct 23, 2017 · 1 comment

Comments

@ernestbofill
Copy link

Since the beta version of Bootstrap, the margin of the horizontal rule defined in _type.scss is a hard-coded making it difficult to customize.

In latest alpha:

// type.scss line 53:
hr {
  margin-top: $spacer-y;
  margin-bottom: $spacer-y;
  //...
}

In beta:

// type.scss line 53:
hr {
  margin-top: 1rem;
  margin-bottom: 1rem;
  //...
}

I would like this margin to use a variable so that it can be customized.

@andresgalante
Copy link
Collaborator

Hi @ernestbofill it was updated here: ed1de86

I'll create a PR to add hr variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants