Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The bottom of truncated headings text is not visible #23956

Closed
ysds opened this issue Sep 15, 2017 · 2 comments
Closed

The bottom of truncated headings text is not visible #23956

ysds opened this issue Sep 15, 2017 · 2 comments

Comments

@ysds
Copy link
Member

ysds commented Sep 15, 2017

When I use a bootstrap heading with text-truncate, the bottom of text is not visible.

image

jsfiddle: https://jsfiddle.net/qx1b4sLu/

I know how to fix it (make line-height equal or larger than font-size). However, I think that it will be very useful if it is defined by default when heading and text-truncate are used together.

@mdo
Copy link
Member

mdo commented Oct 2, 2017

Yeah we should increase the line-height. Hoping 1.25 or similar works?

@ysds
Copy link
Member Author

ysds commented Oct 4, 2017

@mdo
In my case, I overwrote line-heght to 1.3 like:

h1, h2, ..., .h6 {
 &.text-truncate {
    line-height: 1.3;
  }
}

However, top and bottom space of these headings are slightly different from other headings that doesn't have text-truncate class (= line-height: 1.1). Unfortunately I have no idea to make them the same height.

@mdo mdo added the has-pr label Oct 18, 2017
mdo added a commit that referenced this issue Oct 18, 2017
This way, descenders are not cropped when truncating. Fixes #23956.
mdo added a commit that referenced this issue Oct 18, 2017
This way, descenders are not cropped when truncating. Fixes #23956.
mdo added a commit that referenced this issue Oct 19, 2017
This way, descenders are not cropped when truncating. Fixes #23956.
@mdo mdo mentioned this issue Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants